Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api permission #283

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Add api permission #283

merged 2 commits into from
Dec 26, 2023

Conversation

ericgaspar
Copy link
Member

@ericgaspar ericgaspar commented Dec 23, 2023

Problem

  • In case of ha is not open to visitors :
    • authenfication will be done by ssowat and then homeassitant authentification system
    • api can be accessed with a TOKEN but ssowat need to be bypassed

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@ewilly
Copy link
Member

ewilly commented Dec 26, 2023

I hope i well guess the purpose of your PR ;-)

@ewilly ewilly merged commit 1f8f09b into testing Dec 26, 2023
1 check passed
@ericgaspar ericgaspar deleted the add-api-permission branch December 26, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants