Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade from a previous commit #63

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Apr 11, 2018

Problem

  • Test an upgrade for each PR is boring...

Solution

  • Add a test "Upgrade from commit" in the check_process

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : Josué
  • Approval (LGTM) : JimboJoe
  • CI succeeded : Build Status
    When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

@maniackcrudelis maniackcrudelis requested a review from a team April 11, 2018 19:16
Copy link

@Josue-T Josue-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 👍
Thanks

@maniackcrudelis maniackcrudelis requested a review from a team April 13, 2018 15:06
Copy link
Contributor

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe
Copy link
Contributor

Will be merged in 3 days.

@JimboJoe JimboJoe merged commit 586d470 into testing Apr 16, 2018
@JimboJoe JimboJoe deleted the Add-upgrade-from-a-previous-commit branch April 16, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants