Upgrade to v0.2.2 & signald properly & linter #36

Gredin67 · 2022-01-03T13:20:58Z

Problem

helper does not upgrade
code is messy

Solution

simply use repaired helper [fix] Force dependencies upgrade even if previous version is accepted YunoHost/yunohost#1407
synchronize code with cleaned-up Whatsapp bridge Update restore mautrix_whatsapp_ynh#42

PR Status

Package_check results

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

Gredin67 · 2022-01-03T13:26:27Z

!gogogadgetoci

yunohost-bot · 2022-01-03T13:26:31Z

May the CI gods be with you!

MayeulC · 2022-01-04T15:14:17Z

TO BE CONFIRMED: signald does not store user data, which are stored in mautrix_signal DB

That assumption is wrong: you can check it with signaldctl.

I like the idea, but that feels like a kludge. I think #34 is a better approach. It was stalled for a bit due to a broken CI, but let's see if I can make it work.

Gredin67 · 2022-01-05T09:14:26Z

I'm in contact with YunoHost maintainers to try to solve the helper issue.

MayeulC · 2022-01-05T14:03:49Z

#34 seems to be in good shape now. It's a bit harder to maintain as checksums have to be updated, but on the other hand, I really like the fact that packages are pinned to a verified version, so I think we can go with it for now.

I'm going to test on my server, then merge this into testing, and finally upgrade to 0.2.1.

scripts/upgrade

alexAubin · 2022-01-09T17:36:50Z

Pending fix in core for the upgrade issue: YunoHost/yunohost#1407

* add e2e encryption * avoid dev headers

alexAubin · 2022-01-16T21:09:13Z

(Fix in the core was released in stable a couple days ago)

* Update README.md * prepare for add to app list * restore signald user data folder * clean-up and sync whatsapp_ynh * Update app.src * Update manifest.json Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Yunohost-Bot <>

Gredin67 · 2022-01-18T12:52:19Z

!gogogadgetoci

yunohost-bot · 2022-01-18T12:52:23Z

🎠

Gredin67 · 2022-01-19T08:58:46Z

!testme

yunohost-bot · 2022-01-19T08:58:50Z

🚀

scripts/upgrade

MayeulC · 2022-01-20T15:12:10Z

I can try to address some of these comments myself if you want, but I didn't really want to change some of that without your consent.

Gredin67 · 2022-01-20T15:15:22Z

upgrading the source file does not require review, just CI test
There was a PR about linting which was opened for long time and nobody reviewed, so I improved it and merged
the mautrix_signal upgrade has been fixed in the core, not here --> would be happy if someone confirms that signald actually upgrades now

This will be squashed, and nobody cares about a Yunohost package history. That's why I don't care about messing up the history.

Feel free to review this one or split it and review if you think that makes sense ;) I will check you review and take the necessary changes

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Gredin67

I integrated most things, closed some that I think are not useful or should belong to another PR. Things that are still open require more discussion or to do some modifications.

doc/DISCLAIMER.md

Gredin67 · 2022-01-20T15:48:14Z

doc/DISCLAIMER_fr.md

+* Par défaut, seules les conversations avec des messages très récents seront mises-en-miroir
+* Acceptez les invitations aux salons
+
+#### Enregistrer la passerelle comme appareil principal


can you check and do it?

Gredin67 · 2022-01-20T15:49:46Z

manifest.json

+			{
+				"name": "bot_synapse_adm",
+				"type": "boolean",
+				"ask": {
+					"en": "Give the WhatsApp bot administrator rights to the Synapse instance?",
+					"fr": "Donner au robot WhatsApp des droits administrateur à l'instance Synapse ?"
+				},
+				"help": {
+					"en": "If true, the bot can group WhatsApp chats in a Matrix space. Not required if you set up Synapse so that non-admins are authorized to create spaces.",
+					"fr": "Si true, le robot groupera les conversations WhatsApp dans un espace Matrix. Pas nécessaire si vous avez réglé Synapse pour qu'il autorise les non-admin à créer des espaces."
+				},
+				"default": true
+			},			


again, to be checked. Yep for the typo

manifest.json

scripts/_common.sh

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Necessary as the group is created by the dependencies

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

nathanael-h and others added 3 commits December 6, 2021 18:45

Upgrade to v0.2.1

0f20533

remove extra_dep before upgrade

3197d0c

do not specify signald version

5a26223

Gredin67 mentioned this pull request Jan 3, 2022

Investigate signald upgrade #22

Closed

Gredin67 linked an issue Jan 3, 2022 that may be closed by this pull request

Investigate signald upgrade #22

Closed

alexAubin reviewed Jan 9, 2022

View reviewed changes

scripts/upgrade Outdated Show resolved Hide resolved

Gredin67 added 3 commits January 9, 2022 18:55

Add support for end-to-bridge encryption (#37)

a7a88d3

* add e2e encryption * avoid dev headers

Update upgrade

9075b8a

source url has changed

4d81509

Gredin67 mentioned this pull request Jan 17, 2022

Use debs for updating instead of relying on ynh helper #34

Closed

5 tasks

Linter and sync whatsapp_ynh (#27)

36a2c4a

* Update README.md * prepare for add to app list * restore signald user data folder * clean-up and sync whatsapp_ynh * Update app.src * Update manifest.json Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Yunohost-Bot <>

Gredin67 changed the title ~~Upgrade to v0.2.1 & upgrade signald properly~~ Upgrade to v0.2.2 & upgrade signald properly Jan 18, 2022

Gredin67 changed the title ~~Upgrade to v0.2.2 & upgrade signald properly~~ Upgrade to v0.2.2 & signald properly & linter Jan 18, 2022

Gredin67 added 5 commits January 18, 2022 14:42

python3-dev

f5bad21

no python-olm

6d872af

Update restore

af36e5c

Update upgrade

239e4e6

remove weight

d74cbbd

check upgrade from 0.2.0

a581139

MayeulC reviewed Jan 20, 2022

View reviewed changes

scripts/upgrade Show resolved Hide resolved

Gredin67 and others added 2 commits January 20, 2022 16:19

Update README.md

564a9d7

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Auto-update README

901417d

Gredin67 commented Jan 20, 2022

View reviewed changes

Gredin67 and others added 22 commits January 20, 2022 17:11

Update scripts/upgrade

c0b46c5

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Apply suggestions from code review

d14e286

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Auto-update README

9ba0a57

Update restore

3b310ac

Fix restore by installing dependencies before adding user

3b91e1c

Necessary as the group is created by the dependencies

Replace Whatsapp typos with Signal

db8ef10

Fix service description inconsistency in install/upgrade/restore

c6c2b77

Apply suggestions from code review

5db4833

Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>

Auto-update README

04014c1

comment out bot_synapse_adm for now

30d09a4

Update upgrade

452a4eb

Update manifest.json

fa51f17

remove hack for signald permissions

c2ffc04

Update manifest.json

4b12be9

Auto-update README

c14efeb

Update manifest.json

44abcbe

Auto-update README

69f8aff

deactivate encryption by default

dcd5149

Update upgrade

5c81dc7

no encryption in manifest

bc39d3c

fix db_pwd upgrade

19322b7

Update config.yaml

635531a

Gredin67 merged commit 66c49f0 into master Jan 25, 2022

Gredin67 deleted the testing branch February 2, 2022 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to v0.2.2 & signald properly & linter #36

Upgrade to v0.2.2 & signald properly & linter #36

Gredin67 commented Jan 3, 2022 •

edited

Loading

Gredin67 commented Jan 3, 2022

yunohost-bot commented Jan 3, 2022

MayeulC commented Jan 4, 2022

Gredin67 commented Jan 5, 2022

MayeulC commented Jan 5, 2022

alexAubin commented Jan 9, 2022

alexAubin commented Jan 16, 2022

Gredin67 commented Jan 18, 2022

yunohost-bot commented Jan 18, 2022

Gredin67 commented Jan 19, 2022

yunohost-bot commented Jan 19, 2022

MayeulC commented Jan 20, 2022

Gredin67 commented Jan 20, 2022

Gredin67 left a comment

Gredin67 Jan 20, 2022

Gredin67 Jan 20, 2022

Upgrade to v0.2.2 & signald properly & linter #36

Upgrade to v0.2.2 & signald properly & linter #36

Conversation

Gredin67 commented Jan 3, 2022 • edited Loading

Problem

Solution

PR Status

Package_check results

Gredin67 commented Jan 3, 2022

yunohost-bot commented Jan 3, 2022

MayeulC commented Jan 4, 2022

Gredin67 commented Jan 5, 2022

MayeulC commented Jan 5, 2022

alexAubin commented Jan 9, 2022

alexAubin commented Jan 16, 2022

Gredin67 commented Jan 18, 2022

yunohost-bot commented Jan 18, 2022

Gredin67 commented Jan 19, 2022

yunohost-bot commented Jan 19, 2022

MayeulC commented Jan 20, 2022

Gredin67 commented Jan 20, 2022

Gredin67 left a comment

Choose a reason for hiding this comment

Gredin67 Jan 20, 2022

Choose a reason for hiding this comment

Gredin67 Jan 20, 2022

Choose a reason for hiding this comment

Gredin67 commented Jan 3, 2022 •

edited

Loading