Prevent sysctl use in any lxc container #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
Alrighty! |
|
Your patch looks good to me (FWIW, I am not the maintainer of this app). I'd just suggest to also remove the |
Salamandar
force-pushed
the
prevent_systctl_in_all_container
branch
from
260b6b1
to
4b8e905
Compare
|
Rebased on latest testing. |
|
!testme |
|
✌️ |
I missed this comment! Indeed... I pushed a commit that removes _common.sh, as it is now empty. |
autra
force-pushed
the
prevent_systctl_in_all_container
branch
from
283722a
to
1602d10
Compare
|
actually backtracking : I just removed the package check bypassing but I kept common.sh, until I hear from a reviewer, as it is in example_ynh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use ./ynh-dev and lxc containers to experiment, test, bugfix yunohost and applications. For this reason I propose to exclude sysctl exclusion on all lxc containers, not only in package_check CI.
This will allow me to restore backups taken from my instance in test instances, for example.
Thanks!