Testing

[maniackcrudelis]

Problem

• Instal doesn't work on stretch

Solution

• Add php-zip as a dependence Fix stretch #96

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

---

Minor decision

• Upgrade previous version :
• Code review : JimboJoe from Fix stretch #96
• Approval (LGTM) : JimboJoe from Fix stretch #96
• Approval (LGTM) : frju365 from Fix stretch #96
• CI succeeded :
  When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

[frju365]

perhaps let's merge it quickly ?

[maniackcrudelis]

Are we in such a hurry ?

[frju365]

no, but we 4 reviews and it's a little fix ;)

[maniackcrudelis]

4 reviews for a PR currently in "pending"...
Not that I don't want to take notice of your reviews, but our procedure is to let to a testing release 7 days (at least) to be tested by the community, then if no other commits are added and if no regressions have been mentioned, we can start to review it.

Of course, if no commits are added until these 7 days, I will consider these reviews. But what if we have to rewrite this PR because of a regression or new commits ?
There's no security issue here, so let's not fall in a useless hastiness. I know that our procedure can be sometimes frustrating, but it's also a guaranty of quality for our apps.

So, for my part, I rather prefer to wait since there's no fix except for stretch (which I already try with success). So let's be sure this stretch fix will not break jessie.

[frju365]

yes, yes, of course. I didn't mean to merge it today. (I didn't need a so long explanation ;-) )

[maniackcrudelis]

Will be merged in 3 days