Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Cache control on mjs files #616

Merged
merged 1 commit into from
Oct 21, 2023
Merged

[enh] Cache control on mjs files #616

merged 1 commit into from
Oct 21, 2023

Conversation

zamentur
Copy link
Contributor

Problem

No cache on mjs files

Solution

Add simply mjs files to the location.
Note that the official doc use a tricks to manage in a better way the cache (we just have Expire 6M...
https://docs.nextcloud.com/server/latest/admin_manual/installation/nginx.html#nextcloud-in-a-subdir-of-the-nginx-webroot

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member

What preventing us to include this block?:

    include mime.types;
    types {
        text/javascript js mjs;
    }

@ericgaspar ericgaspar merged commit 1c9ca44 into testing Oct 21, 2023
@ericgaspar ericgaspar deleted the mjs branch October 21, 2023 19:31
@ericgaspar ericgaspar mentioned this pull request Oct 21, 2023
@ericgaspar
Copy link
Member

This should be fixed with #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants