Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing : 6.0.2 + packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init #391

Merged
merged 108 commits into from
Dec 28, 2023

Conversation

ericgaspar
Copy link
Member

@ericgaspar ericgaspar commented Oct 17, 2023

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@alexAubin alexAubin changed the title Testing : fix install 502 error + timeout on slow hardware + wait for DB full init Testing : packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init Dec 27, 2023
@alexAubin
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@alexAubin alexAubin changed the title Testing : packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init Testing : 6.0.2 + packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init Dec 27, 2023
@alexAubin
Copy link
Member

Sooo tests are passing, for me we're good to go 👍

@ericgaspar ericgaspar merged commit 2114cc9 into master Dec 28, 2023
@lapineige
Copy link
Member

That install didn't work on my server… I already had a report of a failed update.

A so massive change requires manual testing imho…

@alexAubin
Copy link
Member

It it fails then can we have logs x_x ...

@lapineige
Copy link
Member

lapineige commented Dec 29, 2023

So I tried again (on 2 instances) with your latest changes, and it works now. I don't know what fixed it.

But for someone else, it failed. Logs : https://paste.yunohost.org/raw/yecofedamu

INFO - Provisioning database...
DEBUG - Executing command '['sh', '-c', '/bin/bash -x "./upgrade"  7>&1']'
DEBUG - + source _common.sh
DEBUG - ++ nodejs_version=20
DEBUG - +++ echo peertube
DEBUG - +++ sed s/peertube//g
DEBUG - ++ db_suffix=
DEBUG - + source /usr/share/yunohost/helpers
DEBUG - +++ set +o
DEBUG - +++ grep xtrace
DEBUG - ++ readonly 'XTRACE_ENABLE=set -o xtrace'
DEBUG - ++ XTRACE_ENABLE='set -o xtrace'
WARNING - ./upgrade: line 16: admin: unbound variable
DEBUG - + admin_mail=
DEBUG - + ynh_exit_properly
DEBUG - + [[ upgrade =~ ^install$|^upgrade$|^restore$ ]]
ERROR - Could not upgrade peertube: An error occurred inside the app upgrade script

@ericgaspar
Copy link
Member Author

I have pushed to testing some fixes for the NGINX config:
__DATA_DIR__storage/ to __DATA_DIR__/storage/
I don't know if this solve issues beeing reported in the forum.

@lapineige
Copy link
Member

So referencing it #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants