Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing : 0.11.6 (various fixes for v0.11.5 : media/s3/…) #210

Merged
merged 14 commits into from
May 3, 2023

Conversation

lapineige
Copy link
Member

@lapineige lapineige commented Apr 10, 2023

#209 and then v0.11.6 #214

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige and others added 7 commits April 4, 2023 17:29
See pixelfed/pixelfed@573c88d : this config line as to be removed, it might broke S3 storage.
And #208
Exceptionally using a commit number for testing purpose (and maybe real fix)
v0.11.5 fixes :  S3, media storage, …
@yalh76
Copy link
Member

yalh76 commented Apr 19, 2023

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@lapineige
Copy link
Member Author

It's the very same as #209 (comment), nothing change since that time.
So I'm cancelling CI. This needs manual testing.

@wesleycook74
Copy link

wesleycook74 commented May 1, 2023

Edit: Nevermind, I was mistaken. It seemed like it was working but not actually.

I was finally able to fix this issue on my server by updating to this branch and then setting the filesytem config like so

        'local' => [
            'driver' => 'local',
            'root'   => storage_path('app'),
            'permissions' => [
                'file' => [
                    'public' => 0644,
                    'private' => 0660,
                ],
                'dir' => [
                    'public' => 0775,
                    'private' => 0770,
                ],
            ],
        ],

@lapineige
Copy link
Member Author

Edit: Nevermind, I was mistaken. It seemed like it was working but not actually.

Too bad :(

@lapineige lapineige mentioned this pull request May 3, 2023
2 tasks
@lapineige lapineige changed the title Testing : fix 0.11.5 media/s3/… Testing : 0.11.6 (various fixes for v0.11.5 : media/s3/…) May 3, 2023
@lapineige
Copy link
Member Author

This adds improvements while not fixing the image upload bug, so the discussion will continue here, but I'm merging it anyway.

@lapineige lapineige merged commit 46e17a8 into master May 3, 2023
@lapineige lapineige added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants