Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #77

Merged
merged 3 commits into from Mar 17, 2020
Merged

Testing #77

merged 3 commits into from Mar 17, 2020

Conversation

JimboJoe
Copy link
Contributor

@JimboJoe JimboJoe commented Mar 5, 2020 •
edited by kay0u

Problem

  • The application is not up-to-date with the upstream

Solution

  • Upgrade to latest version 1.4.3

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@JimboJoe JimboJoe requested a review from a team March 14, 2020 08:07
@kay0u
Copy link
Member

kay0u commented Mar 14, 2020

Can be merged in 3 days

@JimboJoe JimboJoe merged commit eafad8e into master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JimboJoe @kay0u @maniackcrudelis @alexAubin