Testing : set file permissions after creating the log (#53) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexAubin
reviewed
Apr 17, 2020
| # set proper permissions | ||
| ynh_print_info "Set permissions..." | ||
| find $final_path -type f | xargs chmod 644 | ||
| find $final_path -type d | xargs chmod 755 |
There was a problem hiding this comment.
Uh I have no idea what I'm talking about but is it really what we wanna do here ?
Is it okay that all users on the system will be able to read every file in /var/www/$app ? Are we sure that there's absolutely no info that should stay private in that folder ?
There was a problem hiding this comment.
Good point, I don't see any reason to do that.
|
Bump! I think this can me merged in a first time; |
|
Then we need to assess that file permission issue… |
lapineige
added a commit
that referenced
this pull request
Nov 1, 2020
* Set file permissions after creating the log (#53) (#54) Should fix #49 Authored-by: tituspijean <tituspijean@outlook.com> * Updated to version v0.12.0 * Fix images * Fixed path in nginx Co-authored-by: lapineige <lapineige@users.noreply.github.com> Co-authored-by: anmol <anmol@jswan2.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com>
lapineige
added a commit
that referenced
this pull request
Nov 30, 2020
* Set file permissions after creating the log (#53) Should fix #49 * Updated to V0.12.0 and Nginx fix (#57) * Set file permissions after creating the log (#53) (#54) Should fix #49 Authored-by: tituspijean <tituspijean@outlook.com> * Updated to version v0.12.0 * Fix images * Fixed path in nginx Co-authored-by: lapineige <lapineige@users.noreply.github.com> Co-authored-by: anmol <anmol@jswan2.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README.md * rm -r -> ynh_secure_remove (#59) * Update issue_template.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update openssl dependency Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update _common.sh - Remove unused script that generates an error - Remove openssl that is part of PHP as default * Cleaning up * Fix linter warnings * Small typos (#60) * Patch2 (#61) - Fix NGINX 302 redirect - Fix missing upgrade_type in upgrade script - Add ynh_smart_mktemp helper * Fix NGINX * Re-implement automatic post-installation * Ensure file and directories permissions in upgrade * Replace all ynh_print_info with ynh_script_progression * Update check_process * Use permissions system Co-authored-by: tituspijean <tituspijean@outlook.com> Co-authored-by: anmol26s <5068843+anmol26s@users.noreply.github.com> Co-authored-by: anmol <anmol@jswan2.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49
Should we add something in the upgrade script to fix current configurations ?