Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade synapse to 0.99.3 #115

Merged
merged 1 commit into from May 3, 2019
Merged

Upgrade synapse to 0.99.3 #115

merged 1 commit into from May 3, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Apr 4, 2019 •
edited

Problem

  • The app is not up to date

Solution

  • Update the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@Josue-T Josue-T requested a review from a team April 4, 2019 20:12
kay0u
kay0u approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Josue-T Josue-T merged commit c9a1e40 into testing May 3, 2019
@Josue-T Josue-T deleted the v0.99.3 branch May 3, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josue-T @kay0u @maniackcrudelis