Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade synapse to 0.99.3.2 #120

Merged
merged 1 commit into from May 10, 2019
Merged

Upgrade synapse to 0.99.3.2 #120

merged 1 commit into from May 10, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented May 4, 2019 •
edited

Problem

Solution

  • Upgrade the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe
JimboJoe approved these changes May 4, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review 👍

@JimboJoe JimboJoe requested a review from a team May 4, 2019 12:39
kay0u
kay0u approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI fail everything

@Josue-T
Copy link
Author

Josue-T commented May 5, 2019 •
edited

LGTM, but the CI fail everything

We probably need to relaunch the test, I've tested on the ci-dev and it passed

@Josue-T
Copy link
Author

Josue-T commented May 6, 2019

@maniackcrudelis can you relaunch the test on the CI. I don't have the access to the "ci-apps-hq".

@Josue-T Josue-T merged commit 33e60d3 into testing May 10, 2019
@Josue-T Josue-T deleted the v0.99.3.2 branch May 10, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josue-T @JimboJoe @kay0u