Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #134

Merged
merged 5 commits into from Jul 21, 2019
Merged

Testing #134

merged 5 commits into from Jul 21, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Jul 11, 2019 •
edited by JimboJoe

Problem

  • The package is not up to date

Solution

  • Update the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@lapineige
Copy link
Member

lapineige commented Jul 11, 2019 •
edited

Upgraded successfully 👌

Thanks for the work :)

kay0u
kay0u approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

@kay0u kay0u mentioned this pull request Jul 16, 2019
Closed
JimboJoe
JimboJoe approved these changes Jul 16, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe
Copy link

Can be merged in 3 days.

@Thatoo
Copy link

Thatoo commented Jul 21, 2019

Can be merged in 3 days.

@Josue-T : Is it possible to merge today? I'm sorry, it's just that it's sunday I have more time to take care of the server, do backup and upgrade. I hope I'm not bothering you too much by notifying you.
I hope this update will solve the crazy ram consumption of my synapse server since the last update.

@lapineige
Copy link
Member

@Thatoo : yunohost app upgrade synapse -u https://github.com/YunoHost-Apps/synapse_ynh and you're done :)

@kay0u kay0u merged commit ce1d457 into master Jul 21, 2019
@kay0u
Copy link
Member

kay0u commented Jul 21, 2019

Merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Josue-T @lapineige @JimboJoe @Thatoo @kay0u