Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade synapse to 1.5.1 #153

Merged
merged 5 commits into from Nov 12, 2019
Merged

Upgrade synapse to 1.5.1 #153

merged 5 commits into from Nov 12, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Oct 7, 2019 •
edited by JimboJoe

Problem

  • The package is not up to date

Solution

  • Update

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) :
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@MayeulC
Copy link

MayeulC commented Oct 12, 2019

How is this dealing with the changes to the mail invites configuration ?

@Thatoo
Copy link

Thatoo commented Oct 30, 2019

v 1.5?

@Josue-T Josue-T requested a review from a team October 31, 2019 19:02
Thatoo
Thatoo previously approved these changes Nov 1, 2019
View reviewed changes
@Josue-T Josue-T changed the title Upgrade synapse to 1.4.0 Upgrade synapse to 1.5.1 Nov 8, 2019
@Josue-T Josue-T requested review from a team and removed request for a team November 8, 2019 22:44
JimboJoe
JimboJoe approved these changes Nov 9, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe JimboJoe requested a review from a team November 9, 2019 11:12
kay0u
kay0u approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay0u
Copy link
Member

kay0u commented Nov 9, 2019

Can be merged in 3 days

@Josue-T Josue-T merged commit 2b8c998 into testing Nov 12, 2019
@Josue-T Josue-T deleted the v1.4 branch November 12, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

@Thatoo Thatoo Thatoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Josue-T @MayeulC @Thatoo @kay0u @JimboJoe