Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAS - SSO implementation #175

Merged
merged 15 commits into from Apr 3, 2020
Merged

CAS - SSO implementation #175

merged 15 commits into from Apr 3, 2020

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Feb 22, 2020 •
edited by JimboJoe

Problem

  • Unitil now, the SSO in Riot was implemented on the Riot side because there was no SSO implemented in Synapse and Riot. But now a SSO has been implemented with CAS. The SSO implemented in the Riot package is complicated to maintain because it's a patch of compressed Javascript code.

Solution

  • Implement the CAS authentication in synapse.

Note that to have this to work we need Yunohost 3.7 and this branch for SSOwat (thanks @kay0u) 馃憤 .

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@kay0u kay0u mentioned this pull request Feb 25, 2020
Closed
@Josue-T
Copy link
Author

Josue-T commented Mar 17, 2020

Now it work well with the actual testing (3.7).

@Josue-T Josue-T mentioned this pull request Mar 19, 2020
Closed
@Josue-T Josue-T requested a review from a team March 30, 2020 08:59
@Josue-T
Copy link
Author

Josue-T commented Mar 30, 2020

Ready for review

kay0u
kay0u reviewed Mar 30, 2020
View reviewed changes
conf/homeserver.yaml Show resolved Hide resolved
scripts/restore Show resolved Hide resolved
scripts/backup Show resolved Hide resolved
sources/cas_server.php Show resolved Hide resolved
conf/remove_sso_conf.py Show resolved Hide resolved
kay0u
kay0u previously approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

(I think precise on which domain remove the SSO in the python script is better though)

kay0u
kay0u reviewed Mar 31, 2020
View reviewed changes
scripts/change_url Outdated Show resolved Hide resolved
@Josue-T @kay0u
Update scripts/change_url
ddf0b57 
Co-Authored-By: Kayou <pierre.moltess@gmail.com>
kay0u
kay0u approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

JimboJoe
JimboJoe approved these changes Mar 31, 2020
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@JimboJoe
Copy link

Can be merged in 3 days.

@Josue-T Josue-T merged commit 57a79f8 into testing Apr 3, 2020
@Josue-T Josue-T deleted the sso branch April 3, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josue-T @JimboJoe @kay0u