v1.68, add administration API protection, various fixes #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josué Tille <josue@tille.ch>
Fix change_url's ynh_permission_url parameters
|
!testme |
|
✌️ |
Josue-T
approved these changes
Sep 27, 2022
tituspijean
changed the title
|
Maybe we should just completely open the |
|
As you prefer! :) |
|
I think as it's an API it should not be a security issue to open completely this path. |
Josue-T
reviewed
Oct 19, 2022
See coturn/coturn@8a60754 Option removed in 4.5.2. This was a sane default before, but now coturn complains on startup that this option is invalid: > Bad configuration format: no-loopback-peers See also: cve-2020-26262 GHSA-6g6j-r9rf-cm7p https://www.rtcsec.com/article/cve-2020-26262-bypass-of-coturns-access-control-protection/ https://www.mageni.net/vulnerability/coturn-452-loopback-bypass-vulnerability-145204
turnserver.conf: remove no-loopback-peers
|
!testme |
|
Fingers crossed! |
|
Well, I'm seeing now that there are missing here some important part. The nginx config !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)