Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change configuration #22

Open
xplosionmind opened this issue Jan 17, 2022 · 10 comments
Open

Cannot change configuration #22

xplosionmind opened this issue Jan 17, 2022 · 10 comments

Comments

@xplosionmind
Copy link

Describe the bug

App is useless since I cannot change the configuration: after saving it, it is restored as it was originally.

Context

Hardware: VPS bought online
YunoHost version: 4.3.6
I have access to my server : Through SSH
Are you in a special context or did you perform some particular tweaking on your YunoHost instance ? : no

Steps to reproduce

  • successfully install the app
  • in the config panel, change settings (any setting)
  • click on “save”
  • no change is registered in the settings

Expected behavior

Configuration should change accordingly.

Logs

here

@spctrlth
Copy link

spctrlth commented Feb 7, 2022

Same here, it seems like it looks for a key name which it can't find and then looks in the wrong place for the config file (/etc/yunohost/apps//settings.yml, which should probably be /etc/yunohost/apps/unattended_upgrades/settings.yml, so my guess is that the name key should have the value unattended_upgrades).

Unknown key 'name' found in config panel
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Reading config panel description and current configuration...
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
File /etc/yunohost/apps//settings.yml does not exists
Checking what changed in the new configuration...
Validating the new configuration...
Applying the new configuration...
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Configuration key 'previous_apticron_hour' edited in app settings
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Configuration key 'email_type' edited in app settings
Traceback (most recent call last):
File "", line 5, in
AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Configuration key 'after_apticron_hour' edited in app settings
Configuration of completed
Config updated as expected

@spctrlth
Copy link

spctrlth commented Feb 7, 2022

Edit: Ok, don't do this, it breaks other things

Btw, I did this as a work-aroud now

cd /etc/yunohost/apps/
ls
# Make sure there isn't a file here called `settings.yml`. I don't think there should, but if there is, don't proceed
ln -s /etc/yunohost/apps/unattended_upgrades/settings.yml settings.yml
echo "previous_apticron_hour: '20'" >> settings.yml
echo "after_apticron_hour: '2'" >> settings.yml
echo "email_type: '0'" >> settings.yml

Then I saved the settings again from the admin webinterface

To "remove" this work-around again

cd /etc/yunohost/apps/
rm settings.yml

@utkarshsethi
Copy link

@maniackcrudelis is the app being maintained?

@maniackcrudelis
Copy link
Contributor

Hi @utkarshsethi

I couldn't say that I do maintain that app myself anymore, yet I hope it will be as I use it too.
Regarding the config panel, it seems that there were a lot of changes since I left, on that point I'm pretty sure I'm not up to date, so I wouldn't be able to fix anything about it.

Although, when I did implement the config-panel option, it was clearly stated that it was an experimental feature. The app does work perfectly without it, the config-panel is just a more convenient way to deal with it.

@utkarshsethi
Copy link

So it seems to work when installing, but not on changes.

I ended up re-installing since I was not sure I had done the initial setup at all.

@hanswundersam
Copy link

Hi @maniackcrudelis, thank you for making the unattended upgrades app for Yunohost, really appreciate it! However, would you please mark the app as unmaintained or take it off the app store if you do not plan to look after it any more? It is incredibly frustrating for laypeople users to try and figure out why an app is not working only to find it has been abandoned long ago. Plus: unmaintained software always involves a security and stability risk for users. Thank you!

@orhtej2
Copy link

orhtej2 commented Nov 30, 2023

@hanswundersam the core functionality of updating your system automatically works in my experience, it's the config panel that's borked but not really necessary in my experience.

@hanswundersam
Copy link

Thanks for the reply @orhtej2. When I install the app fresh on YunoHost 11.2.7, unattended upgrades are switched off by default despite the install settings saying otherwise. Also, different from what was stated above in the thread, I cannot see any mention of the config panel being experimental.

grafik

The risk I see is that, like me, unsuspicious users will install this app and then think auto-updates are enabled, only to check back months later to find they run a vulnerable / out-of-date Yunohost. Hence my plea to mark the app as unmaintained, only partly working as expected, or even pull it from the store.

@orhtej2
Copy link

orhtej2 commented Nov 30, 2023

The updates are running fine, it's the config panel that's not populated properly.

But I agree, UX could be better.

@hanswundersam
Copy link

OK but that's what caused me to write my first post: the app doesn't appear to work at all -- I still had to do my updates manually. Could this be a new bug or is there anything that needs to be done after app installation? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants