Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade #84

Merged
merged 2 commits into from Jun 9, 2020
Merged

Fix upgrade #84

merged 2 commits into from Jun 9, 2020

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Jun 9, 2020

Problem

  • wb_conf can be undefined

Solution

  • define wb_conf outside of any if statement

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    Please replace '-NUM-' in this link by the PR number.
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@kay0u
Copy link
Member Author

kay0u commented Jun 9, 2020

yolomerging

@kay0u kay0u merged commit cee1f15 into master Jun 9, 2020
@lapineige
Copy link
Member

Thanks :)

@lapineige lapineige mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kay0u @lapineige