Fix alias_traversal #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimboJoe
reviewed
Jan 24, 2018
| @@ -0,0 +1,51 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
We could depend on YunoHost 2.7.7 and spare the creation of this file.
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| source _common.sh | |||
| source /usr/share/yunohost/helpers | |||
| source _sed | |||
There was a problem hiding this comment.
... and if we depend on 2.7.7, we could maybe have a much easier script... ? 😉
There was a problem hiding this comment.
Yes we could, but as a security fix, it would be better to merge that before. Then work on a refactoring of the change_url script.
|
Only need one small LGTM... maybe @frju365 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
PR Status
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
Minor decision
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.