-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing - Packaging v2 #68
Conversation
!testme |
@@ -133,7 +120,7 @@ import_template () { | |||
then | |||
sid=$(curl $curlOptions \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This curl call and the previous one probably don't work anymore in private install
I'm not sure how it was supposed to work before, but anyway, ideally one should rely on ynh_local_curl which will temporarily make the app public : https://github.com/YunoHost/yunohost/blob/dev/helpers/utils#L435
Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com>
So TL;DR the status is :
|
…nabling access for visitors if needed
Hmokay, I managed to fix the curl issue, let's release this and iterate for bookworm |
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)