Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing - Packaging v2 #68

Merged
merged 15 commits into from
May 1, 2024
Merged

Testing - Packaging v2 #68

merged 15 commits into from
May 1, 2024

Conversation

Salamandar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@Salamandar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🪱
Test Badge

@@ -133,7 +120,7 @@ import_template () {
then
sid=$(curl $curlOptions \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This curl call and the previous one probably don't work anymore in private install

I'm not sure how it was supposed to work before, but anyway, ideally one should rely on ynh_local_curl which will temporarily make the app public : https://github.com/YunoHost/yunohost/blob/dev/helpers/utils#L435

manifest.toml Outdated Show resolved Hide resolved
alexAubin and others added 2 commits May 1, 2024 22:08
Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com>
@alexAubin alexAubin mentioned this pull request May 1, 2024
2 tasks
@alexAubin
Copy link
Member

So TL;DR the status is :

  • this PR is working-ish on bullseye, but the private install probably is broken because there's a raw curl which doesn't properly temporarily enable visitors on the endpoint
  • it doesn't work on bookworm because zabbix 5.x depends on libssl1.1 which doesn't exist anymore on bookworm. We should upgrade to 6.x probably, but as shown in Version 6.4 #46, the initial provisioning of the mysql DB changes (?) and probably a migration need to be performed ?

@alexAubin
Copy link
Member

Hmokay, I managed to fix the curl issue, let's release this and iterate for bookworm

@alexAubin alexAubin merged commit c3675c3 into master May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants