Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging by sidddy #78

Closed
wants to merge 2 commits into from
Closed

Logging by sidddy #78

wants to merge 2 commits into from

Conversation

Psycojoker
Copy link
Member

Hello,

As said there sidddy@e6b220d#commitcomment-22128490 the logging work by @sidddy looks very interesting. To avoid losing this work I'm creating this PR based on this commit (+ removing unrelated things) to avoid losing track of it.

I haven't tested it.

@Psycojoker
Copy link
Member Author

Got this error while playing with it.

2017/05/15 01:26:26 [error] 7370#0: *2 lua entry thread aborted: runtime error: /usr/share/ssowat/log.lua:83: attempt to index local 'fp' (a nil value)
stack traceback:
coroutine 0:
        /usr/share/ssowat/log.lua: in function 'info'
        /usr/share/ssowat/helpers.lua:293: in function 'authenticate'
        /usr/share/ssowat/helpers.lua:820: in function </usr/share/ssowat/helpers.lua:811>, client: 192.168.33.1, server: ynh.local, request: "POST /yunohost/sso/ HTTP/1.1", host: "ynh.local", referrer: "https://ynh.local/yunohost/sso/"

@sidddy
Copy link
Contributor

sidddy commented May 15, 2017

The log file location is hard-coded to "/var/log/nginx/ssowat.log"... probably not a good idea for general usage ;-)

Make sure that:

  1. The directory exists in your environment (or change the corresponding line of code to an alternative directory)
  2. Directory and file are writable by your nginx user

@alexAubin
Copy link
Member

Any news on this ?

@Psycojoker
Copy link
Member Author

I did a quick and dirty integration of the work but never tested it nor tried to make the things for it to work despite having received feedback, so no, nothing on my side :/

@yunohost-bot yunohost-bot modified the milestones: Horizon, 3.x Dec 3, 2017
@Psycojoker Psycojoker removed this from the 3.x milestone Dec 3, 2017
@alexAubin
Copy link
Member

[Semi-automatic message]
Trying to clean PR which are opened and inactive since more than 6 months ~ 1 year ... I propose to close this PR and keep it in the "Horizon" milestone in case somebody wants to take care of it later. But in the meantime there's no point in keeping all of these opened if there's no indication that someone might work on this soon.

@alexAubin alexAubin closed this Nov 29, 2018
@alexAubin alexAubin added this to the Horizon milestone Nov 29, 2018
@alexAubin alexAubin mentioned this pull request Oct 3, 2019
@alexAubin alexAubin deleted the logging branch November 1, 2019 13:17
@alexAubin alexAubin removed this from the Horizon milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants