Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Yunohost App Generator (alias Yologen) #1799

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

lapineige
Copy link
Contributor

A flask webapp to generate a basic (for now) & working Yunohost app using no more than a web form.

@lapineige
Copy link
Contributor Author

One thing that will require some discussion : where should this (flask app) be hosted ?

Right now people willing to try it can use my own hosting, that is not intended to be the final public version. Please contact me (for instance in the matrix room) to get it.

@tituspijean
Copy link
Contributor

We will host it on one of our servers. 😉

@lapineige
Copy link
Contributor Author

lapineige commented Oct 25, 2023

Small bugs to fix:

  • config panel file and conf files have a wrong name
  • in manifest, "not relevant" is not between quotes, and multi-instance "false" is "False"
  • python setting is broken
  • python option needs python3-venv package

tools/app_generator/templates/change_url.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/config.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/remove.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/restore.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/upgrade.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/backup.j2 Outdated Show resolved Hide resolved
tools/app_generator/templates/install.j2 Outdated Show resolved Hide resolved
lapineige and others added 11 commits October 29, 2023 15:44
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
…pdownload with two submit buttons mapped to the same route
@YunoHost YunoHost deleted a comment from lapineige Nov 12, 2023
@alexAubin
Copy link
Member

Imho the remaining roadmap is :

  • test / check / fix the last two blocks (7 and 8)
  • implement i18n using Flask-Babel
  • try packaging a couple apps (that may or may not be already packaged) to check if the output is decent and if there's any obvious stuff that should be taken care of
  • deploy on yunohost's infrastructure ?

@lapineige
Copy link
Contributor Author

lapineige commented Jan 21, 2024

4 issues found in current configuration:

  • configuration file is not generated (no .env in the archive)
  • yarn custom installation setup is reset to default
  • yarn is not even installed
  • multi_instance = true ldap = "false" # TODO : fixme, use actual booleans + handle the "not_relevant" value
    Generated on the same line

@orhtej2
Copy link
Contributor

orhtej2 commented Jan 21, 2024

default restore script restores $install_dir while backup does not declare it for well you know... backup.

@tituspijean
Copy link
Contributor

tituspijean commented Jan 23, 2024

  • "Sources" field should be optional (Python app can only rely on pip to download sources)
  • "multi_instance" and "ldap" fields end up on the same line (and should not be quoted if true or false)
  • Newline missing before "[resources.apt]" and "[resources.database]"
  • Config filename is still "some_config_file" in the upgrade script
  • Restore script does not restart the service
  • No _common.sh file is created

@lapineige
Copy link
Contributor Author

  • While using logrotate, one can't choose a specific logfile.

@lapineige
Copy link
Contributor Author

lapineige commented Feb 13, 2024

@OniriCorpe
Copy link
Contributor

OniriCorpe commented Feb 13, 2024

@lapineige
Copy link
Contributor Author

What are these ? 🤔

@OniriCorpe
Copy link
Contributor

What are these ? 🤔

config files for toml formaters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants