Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash, add a column with the number of opened issues per app #2422

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

nathanael-h
Copy link
Contributor

@nathanael-h nathanael-h commented Jun 19, 2024

Dash, add a column with the number of opened issues per app

  • issues number if > 0
  • number with link to issues page in Gihub
  • sort by issues
  • filter by issues nbr > 0
  • Update translation files (Translate new strings to FR will be done with weblate after)

@nathanael-h
Copy link
Contributor Author

I'll go on tomorrow with the todo list above, time to 💤

@nathanael-h
Copy link
Contributor Author

New column for issues, with filter on apps with 1 or more issues. Work in progress.
image

@nathanael-h
Copy link
Contributor Author

Sort by issues number added :
image

@Salamandar
Copy link
Contributor

Really nice, thanks for the work. What's left to do ? Translations ?

Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com>
@nathanael-h
Copy link
Contributor Author

Yes, the only thing left is translations. But I don't get it. Does the store translated using weblate or not?

@alexAubin
Copy link
Member

Yes it's done through weblate, but you may need to at least regenerate the base .po file I think ? Weblate won't run Flask-Babel itself

(instructions are in the README 😉 )

@nathanael-h
Copy link
Contributor Author

Yep, is enough like this? Or is pybabel update -i messages.pot -d translations && pybabel compile -d translations also needed? Sorry, even with the README I don't get what should be done manually and what is automatically handled by weblate.

@alexAubin
Copy link
Member

I think you need this too yes ... as far as I understand, weblate will just work with the raw .po file (and maybe regenerate the .mo from the .po everytime they get updated by translators) (It's not 100% clear to me either)

@nathanael-h
Copy link
Contributor Author

Done, the PR is ready for review.

@alexAubin alexAubin merged commit 206acfc into YunoHost:master Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants