Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] ffsync: set app notworking and update hash. #86

Merged
merged 1 commit into from Oct 29, 2016
Merged

[mod] ffsync: set app notworking and update hash. #86

merged 1 commit into from Oct 29, 2016

Conversation

M5oul
Copy link
Member

@M5oul M5oul commented Oct 28, 2016

I consider this is a minor vote, following rules needs to be completed before closing this PR:

  • needs three votes. Two others. As mine is given doing this pull request.
  • 66% of positives votes.
  • vote will ends in one week: 4th November 2016.
  • If you consider one this rules is wrong, please ask for modification.

Reasons:

If it works fine on your side, we could put it to inprogress status.

I ping contributors which could have make it works.
@abeudin, @julienmalik, @Josue-T, @lmangani, @matlink

@maniackcrudelis
Copy link
Contributor

Je suis pour

Il ne faut pas garder des app qui ne fonctionne pas. Autant que ce soit indiqué clairement. Elle pourra revenir en in progress si elle est reprise.

Josue-T added a commit to Josue-T/doc that referenced this pull request Oct 29, 2016
Update documentation after this pull : YunoHost/apps#86
Josue-T added a commit to Josue-T/doc that referenced this pull request Oct 29, 2016
Update documentation after this pull : YunoHost/apps#86
@Josue-T
Copy link
Contributor

Josue-T commented Oct 29, 2016

I think mybe there are not a lot of work to do a app how work well, mybe we need to update this doc https://yunohost.org/#/app_ffsync_fr (it's done by this : YunoHost/doc#406 and this YunoHost/doc#407 ). It's not fully documented but just up to date...
And with the new update hash it could run because I had also an error 502 without this commit : beudbeud/ffsync_ynh@7df5d04

But the other things is that actually I don't have time to fix all issues.
It's just my point of view... :-) I understand that it's not a really good app for all people.

@M5oul M5oul merged commit 4515245 into master Oct 29, 2016
@M5oul
Copy link
Member Author

M5oul commented Oct 29, 2016

Sorry, mistake from myself. Clic on wrong PR button :)
Commit canceled on master and pull request migrated to #87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants