Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for high_quality tag for wordpress #881

Merged
merged 1 commit into from Apr 1, 2020

Conversation

@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Mar 18, 2020

Mandatory check boxes:

  • The package is level 7. (Kay0u)
  • The package has been level 7 for at least 1 month. (Kay0u)
  • The package has been in the list for at least 2 months. (Kay0u)
  • The package is up to date regarding the packaging recommendations and helpers. (Kay0u)
  • The repository has a testing branch. (Kay0u)
  • All commits are made in testing branch before being merged into master. (Kay0u)
  • The list points to HEAD, not to a specific commit. (Kay0u)
  • The repository has a pull_request_template.md (Kay0u)
  • The package shows the YunoHost tile yunohost_panel.conf.inc (Kay0u)

Optional check boxes:

  • The package is level 7 for ARM as well. (Kay0u)
    If the app is really important for the community, we can accept it with a broken ARM support. But this should be clearly explained and managed.
  • The app is up to date with the upstream version. (Kay0u)
    If this is possible with the last YunoHost version.
  • The package supports LDAP (Kay0u)
    If the app upstream supports it
  • The package supports HTTP authentication (Kay0u)
    If the app upstream supports it
Mandatory check boxes:
- [ ] The package is level 7.
- [ ] The package has been level 7 for at least 1 month.
- [ ] The package has been in the list for at least 2 months.
- [ ] The package is up to date regarding the packaging recommendations and helpers.
- [ ] The repository has a testing branch.
- [ ] All commits are made in testing branch before being merged into master.
- [ ] The list points to HEAD, not to a specific commit.
- [ ] The repository has a [`pull_request_template.md`](https://github.com/YunoHost/apps/blob/master/pull_request_template-HQ-apps.md)
- [ ] The package shows the YunoHost tile `yunohost_panel.conf.inc`

Optional check boxes:
- [ ] The package is level 7 for ARM as well.
*If the app is really important for the community, we can accept it with a broken ARM support. But this should be clearly explained and managed.*
- [ ] The app is up to date with the upstream version.  
*If this is possible with the last YunoHost version.*
- [ ] The package supports LDAP  
*If the app upstream supports it*
- [ ] The package supports HTTP authentication  
*If the app upstream supports it*
@kay0u

This comment has been minimized.

Copy link
Member

kay0u commented Mar 18, 2020

https://github.com/YunoHost-Apps/wordpress_ynh/blob/71bb63d6e7313acb761928f4a5bda521139ef2aa/conf/nginx.conf#L35-L36

#--PRIVATE-- is not removed during install. (Is it still really necessary?)

Everything else looks good to me 🥇

@kay0u
kay0u approved these changes Mar 18, 2020
@kay0u kay0u requested a review from YunoHost/apps Mar 18, 2020
@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Mar 19, 2020

Indeed, probably forgotten during another upgrade.
I make a PR right now.

@kay0u

This comment has been minimized.

Copy link
Member

kay0u commented Mar 29, 2020

Can be merged in 3 days if no one has anything to add?

@JimboJoe

This comment has been minimized.

Copy link
Member

JimboJoe commented Mar 29, 2020

Nothing to add! 👍

@maniackcrudelis maniackcrudelis merged commit bb00c59 into end_of_official Apr 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@maniackcrudelis maniackcrudelis deleted the request_high_quality_wordpress branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.