ynh_backup_before_upgrade

[yalh76]

Problem

• Just a thinking: during upgrade we start to make some changes to ensure downward compatibility, before doing a backup and even stopping the service, I think backup and stopping the service should be done before making some changes ...
• I'm currently working on bitwarden to vaultwarden name chnage with ynh_handle_app_migration

Solution

• Make backup and service stop, come first

PR Status

• Code finished.
• Tested with Package_check.
• Fix or enhancement tested.
• Upgrade from last version tested.
• Can be reviewed and tested.

Package_check results

---

• An automatic package_check will be launch at https://ci-apps-dev.yunohost.org/, when you add a specific comment to your Pull Request: "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!"*

[alexAubin]

Yup, don't know why the backup was done historically after we start doing changes ...

Not sure about the service stop though, maybe it doesn't matter, idk