script fixes #64
script fixes #64
Conversation
| if is_raspbian ; then | ||
| # Reboot should be done before postinstall to be able to run iptables rules | ||
| info "Your server will now reboot. Please log back in as root and run the post-install." | ||
| reboot |
There was a problem hiding this comment.
Maybe we can add a small delay like sleep 5 here ? (Or even 10 ?) Otherwise the user will see a bunch of messages with no time to read them which is always frustrating ...
Also wondering if it makes sense to call conclusion if we're on raspian but idk
There was a problem hiding this comment.
@alexAubin Agreed for the sleep 5.
I think the conclusion is really important : without it, you're left wondering what to do after the reboot…
There was a problem hiding this comment.
Hmyup my concern is more that people will probably not have the time to read it just in 5 sec ... Maybe the best UX would be to press a key (or enter Y) to agree to reboot after reading the whole thing
There was a problem hiding this comment.
Well you don't need to. The text stays after ssh log-out.
…unless you're using some ssh client that clears the screen after disconnection.
Yeah, a "Press any key to reboot" would be great.
Anyways, could this script be automatically executed automatically at ssh connection ? Or at least, a
echo "Welcome, the yunohost install is not finished, please execute this command: …" could be shown.
|
Something like that could be printed on login : This is done with a file EDIT: Here, I already ran the post-install, so the |
|
@alexAubin Reason for the close ? :( |
|
Hmpf sorry i was just cleaning up a bunch of old branches tonight and indirecly closed the PR ... re-reading i'm confused what this PR is about ... the thing about daemon-reload is now fixed in the core and hmpf idk about the reboot thing for RPi ... people are just supposed to use the preinstalled image (and what happens here is in fact what's used to build the preinstalled image) ... What you mention about "printing stuff on login" is I believe done / handled elsewhere via the yunoprompt stuff ... or there's also this which could be integrated in the install_script but that raises more question that it solve ... Again, people are just supposed to use the preinstalled image ... I'm just lost in what we're trying to solve here |
|
@alexAubin there aren't preinstalled images for all platforms. I have an ARM server that is supported by the Armbian project, but not by Yunohost I think. For the daemon-reload thing, alright. This merge request is only about printing more info to the maintainer during the installation process. |
|
Indeed, but the changes in this PR were about is_raspbian, so only relevant for RPi ... But yeah, the experience could be improved for boards for which we don't have pre installed images, so we could integrate https://github.com/YunoHost/arm-images/blob/yunohost/userpatches/overlay/check_yunohost_is_installed.sh in the install script somehow ... There's also some upcoming improvement to the documentation that may help YunoHost/doc#1491 |
Small script fixes.
I know the
systemctl daemon-reloadissue will be fixed in conf_regen, but calling it once more may prevent any warnings.