Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies consistency check #39

Merged
merged 11 commits into from
Dec 13, 2018
Merged

Add dependencies consistency check #39

merged 11 commits into from
Dec 13, 2018

Conversation

Jibec
Copy link
Contributor

@Jibec Jibec commented May 27, 2018

This follows #38

Many packages have basic issues to be solved, that may create side effects for end-user.

Here us a new warning to make sure dependencies are updated on upgrade and present on restore.

package_linter.py Outdated Show resolved Hide resolved
package_linter.py Outdated Show resolved Hide resolved
@alexAubin
Copy link
Member

Bump ?

@alexAubin
Copy link
Member

According to a message from Jibec on Mastodon, he ain't gonna take care of this PR. Yet the proposed changes are relevant so I implemented the fix for the comments.

I dunno how to run the linter though, so if anybody has time to validate this it'd be nice !

package_linter.py Outdated Show resolved Hide resolved
@alexAubin
Copy link
Member

Bumpz, tested and works on my machine ¯\_(ツ)_/¯

Copy link
Member

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamentur zamentur merged commit d37eaae into YunoHost:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants