-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enh] Add support of moulinette for use-git command #13
Conversation
@@ -193,6 +193,27 @@ elif [ "$1" = "use-git" ]; then | |||
;; | |||
moulinette) | |||
echo "Warning, can't use Git repository for moulinette" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the warning ?
23b1ab2
to
61704b6
Compare
I don't understand why you don't simply simlink the directory and instead do that on each individual files, what's the reason? I think this should be written in a comment. I wonder also if we shouldn't do a "systemctl restart yunohost-api" to takes those changes into account. |
@Psycojoker I guess destination of every symlink is different, so we can't symlink a whole directory. Same as |
@opi if you look at the code, the prefix path if the same for every file so actually can here, no? |
except for locales |
It can't be directly symlink because of the package.py.in file. The setup.py process compile it into a package.py file. Ca ne peut pas être lié directement à cause du fichier package.py. Le setup.py compile ce fichier en un fichier package.py. |
up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it a few days ago, it was working fine. Thanks for this !
No description provided.