Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Add support of moulinette for use-git command #13

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

zamentur
Copy link
Member

No description provided.

@@ -193,6 +193,27 @@ elif [ "$1" = "use-git" ]; then
;;
moulinette)
echo "Warning, can't use Git repository for moulinette"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the warning ?

@zamentur zamentur force-pushed the enh-634-add-moulinette-use-git-support branch from 23b1ab2 to 61704b6 Compare November 15, 2016 22:55
@Psycojoker
Copy link
Member

I don't understand why you don't simply simlink the directory and instead do that on each individual files, what's the reason? I think this should be written in a comment.

I wonder also if we shouldn't do a "systemctl restart yunohost-api" to takes those changes into account.

@opi
Copy link
Contributor

opi commented Nov 16, 2016

@Psycojoker I guess destination of every symlink is different, so we can't symlink a whole directory. Same as yunohost package.

@Psycojoker
Copy link
Member

@opi if you look at the code, the prefix path if the same for every file so actually can here, no?

@opi
Copy link
Contributor

opi commented Nov 16, 2016

except for locales

@zamentur
Copy link
Member Author

zamentur commented Nov 16, 2016

It can't be directly symlink because of the package.py.in file. The setup.py process compile it into a package.py file.


Ca ne peut pas être lié directement à cause du fichier package.py. Le setup.py compile ce fichier en un fichier package.py.

@Psycojoker
Copy link
Member

up

Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it a few days ago, it was working fine. Thanks for this !

@Psycojoker Psycojoker merged commit 26b72bf into master Dec 3, 2016
@Psycojoker Psycojoker deleted the enh-634-add-moulinette-use-git-support branch December 3, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants