Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Sort domains alphabetically #280

Open
wants to merge 1 commit into
base: stretch
Choose a base branch
from

Conversation

cyxae
Copy link
Contributor

@cyxae cyxae commented Dec 6, 2019

The problem

Domains are randomly displayed on the domain page
YunoHost/issues#1355

Solution

Sort domains alphabetically, by top domains

PR Status

...

How to test

Add many domains and subdomains
Use YunoHost/yunohost#860
Go to domain page

(I was unable to test (ynh-dev errors…) but it is a minor change so I suppose it works ^^)

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

When using domains.push, domains are listed in reverse alphabetically order. I assume that using domain.unshift should make the domain list alphabetically sorted
@Aeris1One
Copy link
Contributor

@Aeris1One Aeris1One commented Apr 19, 2020

Best ordering would be to have them sorted in alphabetical order but first domain in list would be the default one (the one with a 🌟)

Ex:

  1. defaultdomain.com (🌟)
  2. alphabeticalfirst.com
  3. endofalphabet.org

@Aeris1One
Copy link
Contributor

@Aeris1One Aeris1One commented Apr 19, 2020

Maybe also a sublist for subdomains ?
But idk how it will render if the default domain is a subdomain 🤔

Ex :

  1. defaultdomain.tld (🌟)
  2. domain.tld
  • sub1.domain.tld
  • sub2.domain.tld
  1. otherdomain.tld
  • sub1.otherdomain.tld

@zamentur zamentur added this to 5.x or more in Pending Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pending
5.x or later / no energy / low priority
3 participants