[enh] Sort domains alphabetically #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using domains.push, domains are listed in reverse alphabetically order. I assume that using domain.unshift should make the domain list alphabetically sorted
|
Best ordering would be to have them sorted in alphabetical order but first domain in list would be the default one (the one with a 🌟) Ex:
|
|
Maybe also a sublist for subdomains ? Ex :
|
|
Superseded by #436 with nested subdomains |
Pending
automation
moved this from 5.x or later / no energy / low priority
to Graveyard
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Domains are randomly displayed on the domain page
YunoHost/issues#1355
Solution
Sort domains alphabetically, by top domains
PR Status
...
How to test
Add many domains and subdomains
Use YunoHost/yunohost#860
Go to domain page
(I was unable to test (ynh-dev errors…) but it is a minor change so I suppose it works ^^)
Validation