Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Sort alphabetically the domain list #860

Merged
merged 2 commits into from Sep 24, 2020
Merged

[enh] Sort alphabetically the domain list #860

merged 2 commits into from Sep 24, 2020

Conversation

cyxae
Copy link
Contributor

@cyxae cyxae commented Dec 6, 2019

The problem

Domains are randomly displayed when running "yunohost domain list"
YunoHost/issues#1355

Solution

Sort domains alphabetically, by top domains

PR Status

...

How to test

Add many domains and subdomains
Run "yunohost domain list"

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@cyxae
Copy link
Contributor Author

cyxae commented Apr 30, 2020

Entre temps le fichier domain.py a changé, il faudrait donc enlever dans mon commit le "['virtualdomain'][0]" mais l'idée reste la même

@zamentur zamentur changed the base branch from stretch-unstable to dev September 22, 2020 13:22
@zamentur
Copy link
Member

I suggested some change and suggest this order in which i group subdomains together following root domain. I think this order allow to groups domains correctly if there is 2 distinct communities

root@ynh:/ynh-dev# yunohost domain list
domains: 
  - juggletube.net
  - www.juggletube.net
  - nextcloud.local
  - revolution.fr
  - vive.la.revolution.fr
  - revolution.it
  - viva.la.revolution.it
  - revolution.net
  - ynh.local

Copy link
Member

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@alexAubin alexAubin merged commit f36a17d into YunoHost:dev Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants