[xmpp] setup http_upload_external #1165
Conversation
|
maybe we can add as advised in https://xmpp.org/extensions/xep-0363.html#server pointed by @randomstuff |
| @@ -14,6 +20,8 @@ do_pre_regen() { | |||
|
|
|||
| # retrieve variables | |||
| main_domain=$(cat /etc/yunohost/current_host) | |||
| http_file_secret=$(cat /etc/yunohost/http_file_secret) | |||
| http_file_delete_secret=$(cat /etc/yunohost/http_file_delete_secret) | |||
There was a problem hiding this comment.
We probably need to rename those files
There was a problem hiding this comment.
sure, what name do you propose ?
| > "${metronome_conf_dir}/${domain}.cfg.lua" | ||
| done | ||
|
|
||
| # create the upload endpoint | ||
| [[ -d "/var/www/metronome/xmmp-upload" ]] \ | ||
| || mkdir -p /var/www/metronome/upload/ |
There was a problem hiding this comment.
Seems a bug "xmpp-upload" vs "upload"
There was a problem hiding this comment.
aie ! yes it's a bug... will change all these soon
|
We should backup and restore the xmpp-upload dir and the secret you added. |
Do we really want to backup the xmpp-upload folder ? if we spawn a new instance somewhere else, metronome will not keep track of the files, and they will stay forever in the folder ... |
| @@ -0,0 +1,189 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Do you know if equivalent script exist in python (we would avoid to add php in dependence of yunohost just for xmpp upload feature ?
There was a problem hiding this comment.
This should not be complicated to rewrite it in python. I just took the official metronome example script. I can do it when I have time
There was a problem hiding this comment.
Could we iterate instead of having the perfect PR ? Because this PR is quite useful.
|
I suggest to use this perl implementation instead https://github.com/weiss/ngx_http_upload . No new dependencies, no daemon to run. There is also a flask implementation: https://github.com/horazont/xmpp-http-upload In any case, Metronome should be a yunohost app, cause a lot of server don't use it. |
The problem
http upload is currently managed by metronome, but it's a deprecated part of metronome which has a limited mime types handling (For example pdf or doc file are not in the default handled mime types).
http upload is not the responsibility of metronome and need to be outsource.
Solution
use the external http upload way describe on metronome documentation.
PR Status
PENDING check/test/approval
How to test