New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Return log after app upgrade with api #359

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@zamentur
Contributor

zamentur commented Aug 28, 2017

Problem

I need to display log info after app upgrade in the web admin

Solution

Do like in yunohost tools upgrade return the log if it's an api call

How to test

This PR is related to the web admin PR YunoHost/yunohost-admin#172
You can test with by upgrading an app

To upgrade an app, you can change the update_time by editing your apps settings /etc/yunohost/apps/APP/settings.yml

PR Status

Opinion needed

Validation

  • Principle agreement 1/2 : Bram
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1:

@zamentur zamentur referenced this pull request Aug 28, 2017

Merged

[enh] Upgrade just one app #172

4 of 4 tasks complete

@Psycojoker Psycojoker merged commit 724f9af into unstable Oct 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Psycojoker

This comment has been minimized.

Show comment
Hide comment
@Psycojoker

Psycojoker Oct 6, 2017

Member

I'm pretty sure we can grab the exact log of the upgrade but this one looks good enough for now (and it's an improvement anyway).

Member

Psycojoker commented Oct 6, 2017

I'm pretty sure we can grab the exact log of the upgrade but this one looks good enough for now (and it's an improvement anyway).

@Psycojoker Psycojoker deleted the enh-add-log-on-app-upgrade branch Oct 6, 2017

@alexAubin alexAubin added this to the 2.7.x (fixes) or 2.8 milestone Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment