New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Do not modify the settings too soon in change_url #376

Closed
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Sep 28, 2017

Problems

If the domain is stored too soon, the backup script, used before any modification, fail because it loads the new domain instead of the old one.
The domain, and the path should be changed only at the end of the script.

Solution

Can't we use the new domain_url_available function instead ?

PR Status

Not tested.
Only a proposition.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
[fix] Do not modify the settings too soon in change_url
## Problems
If the domain is stored too soon, the backup script, used before any modification, fail because is loads the new domain instead of the old one.
The domain, and the path should be changed only at the end of the script.

## Solution
Can't we use the new `domain_url_available` function instead ?

## PR Status
Not tested.
Only a proposition.

## Validation

- [ ] Principle agreement 0/2 : 
- [ ] Quick review 0/1 : 
- [ ] Simple test 0/1 : 
- [ ] Deep review 0/1 :
@alexAubin
Copy link
Member

alexAubin left a comment

Not tested, but that sounds very LGTM ;)

@Psycojoker

This comment has been minimized.

Copy link
Member

Psycojoker commented Sep 29, 2017

I'm wondering if we effectively save the domain after that then, here we just check it.

Otherwise no opposition to that since it's coming from the people best informed about that subject.

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Sep 30, 2017

Ah indeed, as pointed by @Psycojoker , it should probably be more like :

if not domain_url_available(...) :
    # Throw 
    raise MoulinetteException(...)

domain_url_register(...)

(To be tested / implemented)

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Oct 12, 2017

(Flagging as "work needed" for now, because as said we need more than just checking the availability.)

@alexAubin alexAubin added this to the 3.x milestone Jun 13, 2018

@alexAubin alexAubin changed the base branch from stable to stretch-unstable Jun 17, 2018

@alexAubin alexAubin added the inactive label Dec 1, 2018

@Josue-T Josue-T referenced this pull request Dec 30, 2018

Merged

[fix] Fix the way change_url updates the domain/path #608

0 of 4 tasks complete
@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 16, 2019

Closing because superseded by #608

@alexAubin alexAubin closed this Jan 16, 2019

@alexAubin alexAubin deleted the change_url_store_settings branch Jan 16, 2019

@alexAubin alexAubin removed this from the 3.x milestone Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment