Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove warning from equivs #439

Merged
merged 1 commit into from
May 16, 2018
Merged

Conversation

maniackcrudelis
Copy link
Contributor

The problem

equivs-build prints 3 warnings:

dh_install: Compatibility levels before 9 are deprecated (level 7 in use)
dh_installdocs: Compatibility levels before 9 are deprecated (level 7 in use)                       
dh_installdeb: Compatibility levels before 9 are deprecated (level 7 in use)

Solution

Fix the compatibility level at 10 in the compat file used by equivs-build

PR Status

Tested on stretch and jessie.

How to test

Install an app, like piwigo or nextcloud.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about implications it can have, but naively I think it's legit...

Copy link
Member

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems LGTM but... where did you find any (small) piece of information on that subject...? 😵

@maniackcrudelis
Copy link
Contributor Author

The man of debhelper gives a lot of informations about the compatibility levels.
The error message is clear, on stretch we shouldn't use a comptibility level under 9, and 10 "is the recommended mode of operation".

About the emplacement of the compat file, I scavenged internet to find some informations, and finally found that all the files used by equivs were there.

@alexAubin
Copy link
Member

(Merged 8652435 in stretch)

@alexAubin alexAubin added this to the 3.0 milestone Apr 1, 2018
@Psycojoker
Copy link
Member

Do we need to wait for stretch to merge this one? PR indicates that it is working on jessie.

@maniackcrudelis
Copy link
Contributor Author

I would say no, we don't have to wait.

@Psycojoker
Copy link
Member

Ok then, we'll reverse in case of problem.

@Psycojoker Psycojoker merged commit 923ce03 into unstable May 16, 2018
@Psycojoker Psycojoker deleted the compatibility_levels branch May 16, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants