[fix] Set owner of archives folder to 'admin' #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and works as expected |
alexAubin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
c.f. this issue YunoHost/issues#1266
Currently,
admincannot access files in the archive folder,/home/yunohost.backup/archives. This is not such a big deal for now because I guess most people still log as root. But with 3.4 coming where we really discourage root login and encourage admin login, this prevent people from scp-ing backup archives out of their server.Solution
When creating the folder, set
adminas the owner of the folder. + Add a thing in migration n°8 to change the permission for already existing instancesPR Status
Not tested x_x
How to test
Test on a fresh instance, and on a migrated instance that admin can indeed access those files
Validation