New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Set owner of archives folder to 'admin' #613

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

alexAubin commented Jan 14, 2019

The problem

c.f. this issue YunoHost/issues#1266

Currently, admin cannot access files in the archive folder, /home/yunohost.backup/archives. This is not such a big deal for now because I guess most people still log as root. But with 3.4 coming where we really discourage root login and encourage admin login, this prevent people from scp-ing backup archives out of their server.

Solution

When creating the folder, set admin as the owner of the folder. + Add a thing in migration n°8 to change the permission for already existing instances

PR Status

Not tested x_x

How to test

Test on a fresh instance, and on a migrated instance that admin can indeed access those files

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin

This comment has been minimized.

Copy link
Member Author

alexAubin commented Jan 16, 2019

Tested and works as expected

@alexAubin alexAubin changed the title Set owner of archives folder to 'admin' [fix] Set owner of archives folder to 'admin' Jan 17, 2019

@alexAubin alexAubin merged commit 9632164 into stretch-unstable Jan 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix-backup-folder-perms branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment