Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Nginx conf tweaks for theme #689

Merged
merged 4 commits into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

commented Mar 19, 2019

The problem

Currently, only ynhpanel.js is injected in app pages which integrate the yunohost portal button / overlay. This JS currently injects the CSS in the page. This is fine but for theme, we now want to inject two more files (the custom CSS and custom JS) ... and thisis a whole mess because those are then loaded after the inital "DOM loaded" event which makes some stuff harder to implement.

Solution

Inject all those file directly, like ynhpanel.js was.

PR Status

Tested and working

How to test

Try to set a custom theme with YunoHost/SSOwat#122

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin changed the title Tweaks for theme [enh] Nginx conf tweaks for theme Mar 19, 2019

@alexAubin alexAubin referenced this pull request Mar 19, 2019

Merged

Theming reloaded #122

11 of 17 tasks complete

zamentur added some commits Mar 22, 2019

[fix] Keep user info in json format
Previously it was ynhpanel.json
@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

Planning to add this to the 3.5.x which I would like to release early next week ... so this should be merged in the next few days

@alexAubin alexAubin merged commit bdc7853 into stretch-unstable Apr 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the tweaks_for_theme branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.