Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Currently, only ynhpanel.js is injected in app pages which integrate the yunohost portal button / overlay. This JS currently injects the CSS in the page. This is fine but for theme, we now want to inject two more files (the custom CSS and custom JS) ... and thisis a whole mess because those are then loaded
afterthe inital "DOM loaded" event which makes some stuff harder to implement.Solution
Inject all those file directly, like ynhpanel.js was.
PR Status
Tested and working
How to test
Try to set a custom theme with YunoHost/SSOwat#122
Validation