Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `upgrade_only_if_version_changes` in manifest #864

Open
wants to merge 2 commits into
base: stretch-unstable
from

Conversation

@Josue-T
Copy link
Contributor

Josue-T commented Dec 30, 2019

The problem

#756 (comment)

Solution

Implement in the core this concept

PR Status

Work done

How to test

  • Install an app.
  • Add "upgrade_only_if_version_changes":true in the manifest
  • Upgrade an app in debug mode and see that you will have environnement variable named YNH_APP_UPGRADE_TYPE which will give you the type of upgrade. It could be:
    • UPGRADE_FORCED when there are nothing to update but the user forced the update
    • UNKNOWN for the app which don't use the correct syntax for the app version management.
    • UPGRADE_FULL when the upstream and the package need an update.
    • UPGRADE_APP when the upstream need to be updated.
    • UPGRADE_PACKAGE when the package need to be updated.
  • You will see that no upgrade will be done if there are nothing to update but you still can fore this with -F.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Josue-T added 2 commits Dec 30, 2019
@Josue-T Josue-T mentioned this pull request Dec 30, 2019
0 of 4 tasks complete
@Josue-T Josue-T changed the title Abort if up to date manifest Implement `upgrade_only_if_version_changes` manifest Dec 30, 2019
@Josue-T Josue-T changed the title Implement `upgrade_only_if_version_changes` manifest Implement `upgrade_only_if_version_changes` in manifest Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.