-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement upgrade_only_if_version_changes
in manifest
#864
Merged
+104
−7
Merged
Changes from 27 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ebb492f
Add force option in upgrade script
Josue-T ead80c7
Implement upgrade type management and avoid unusefull upgrade
Josue-T 58cce48
Export old and new version in environnement
Josue-T 640a467
Add helper ynh_compare_package_version
Josue-T 4c5edb5
Merge branch 'stretch-unstable' into abort_if_up_to_date_manifest
Josue-T 3484f73
Clean and syntax
maniackcrudelis 14ef523
Improve env_dict variable in upgrade
Josue-T 3d51e23
Add comments
Josue-T fec5d3d
Rename variable
Josue-T 17e8bde
Rename heper
Josue-T 5315807
Cleanup comment
Josue-T 3578588
Replace actual by current
Josue-T f416b94
Put upgrade_only_if_version_changes in integration section
Josue-T d947724
Fix typo
Josue-T ceeb34f
Use 'dpkg --compare-versions'
Josue-T 8dd3986
Fix rename variable
Josue-T 4f0d5ce
Improve version management in '_app_upgradable'
Josue-T a096a36
Also manage downgrade
Josue-T 9389f46
simplification
yalh76 e7970d8
Check settings 'upgrade_only_if_version_changes' before to check upda…
Josue-T 1826e3c
Make more robust version management in upgrade
Josue-T c34de0b
Improve version management in catalog
Josue-T ce6c33a
Fix version key in installed version
Josue-T f2791c9
Make more rebobut version check
Josue-T 01d5c91
Simply code
Josue-T 72b412c
Cleanup code indentation
Josue-T e01859f
Fix tests
alexAubin 5c6b411
Add comment about dependances
Josue-T 95b7885
Merge remote-tracking branch 'upstream/stretch-unstable' into abort_i…
Josue-T 8d2bde8
Install python-packaging as dependance
Josue-T 7c6748e
Merge branch '4.1' into abort_if_up_to_date_manifest
Josue-T 3612ac4
Enable this behavior by default (no need to enable the option in the …
alexAubin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a break change:
-f is used in install operation as in other part of the cli. I suggest to define -F for --file and -f for --force.
This change concerns packagers, and i prefer a break change for packager, than an inconsistency for final users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. : it's used here : https://github.com/YunoHost/package_check/blob/master/sub_scripts/testing_process.sh#L965 so gotta be careful
I'm okay with the change but maybe we can do this in a separate PR to move forward ...