Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revised layout of the website #62

Merged
merged 1 commit into from Oct 29, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 28, 2023

For an example of how to fill this template out, see this Pull Request in the Wiki.

Description

In this PR, I placed the <header/> tag before the <main> tag. Even though the task suggested to Remove landmark tags (like header, footer, aside) from the <main>, I decided to keep it simple and remove one of them as the other parts seem to follow the layout that was created.

Fixes Issue

Closes #49

Acceptance Criteria

  • Remove landmark tags (like header, footer, aside) from the main
  • The <Header /> components appears before the <main> tag
  • <Content /> and <Hero /> components stay inside the since they are containing the information of the main content

Type of Changes

Make sure your code follows the code style of this project.
Make sure your code is up2date.
The title of the PR is the same as the title of the issue.

Type
x πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

before(layout)

After

layout(after)

Testing Steps / QA Criteria

@netlify
Copy link

netlify bot commented Oct 28, 2023

βœ… Deploy Preview for accessibility-mentor ready!

Name Link
πŸ”¨ Latest commit 2dc1643
πŸ” Latest deploy log https://app.netlify.com/sites/accessibility-mentor/deploys/653d61cb57890d0008327bcb
😎 Deploy Preview https://deploy-preview-62--accessibility-mentor.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2 CBID2 marked this pull request as ready for review October 28, 2023 19:46
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 28, 2023

Hi @YuriDevAT! :) My PR is ready for review! :)

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 28, 2023

Hi @YuriDevAT. I made the PR! :)

@YuriDevAT YuriDevAT added the hacktoberfest-accepted Hacktoberfest contribution label Oct 29, 2023
@YuriDevAT
Copy link
Member

Thanks for another contribution πŸ₯³

@YuriDevAT YuriDevAT merged commit b7b9c7a into YurisCodingClub:main Oct 29, 2023
4 of 5 checks passed
@CBID2 CBID2 deleted the fxing-layout branch October 29, 2023 14:36
@CBID2 CBID2 restored the fxing-layout branch October 29, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Layout structure not following guide
2 participants