Support struct in struct
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeHosonuma
commented
Feb 19, 2020
| @@ -3,25 +3,38 @@ | |||
| func elementString<T>(_ x: T, debug: Bool, pretty: Bool) -> String { | |||
| let mirror = Mirror(reflecting: x) | |||
|
|
|||
| let typeName = type(of: x) | |||
| let typeName = String(describing: mirror.subjectType) | |||
There was a problem hiding this comment.
Bugfix: not retrieve really type name when T is Any type.
sahara-ooga
reviewed
Feb 19, 2020
sahara-ooga
reviewed
Feb 20, 2020
| .map { $0.indent(size: prefix.count) } | ||
| .joined(separator: ",\n") | ||
| // Optional<T> | ||
| if typeName.starts(with: "Optional<") { // TODO: better judge is exist? |
There was a problem hiding this comment.
// TODO: better judge is exist?
As you've mentioned in slack, we can use displayStyle property of Mirror type.
https://developer.apple.com/documentation/swift/mirror/displaystyle
Suggested change
| if typeName.starts(with: "Optional<") { // TODO: better judge is exist? | |
| if case .optional = mirror.displayStyle |
There was a problem hiding this comment.
The suggestion is not confirmed yet.
There was a problem hiding this comment.
Thanks for comment, I'll change it in another PR :-)
Co-Authored-By: sahara-ooga <performa532@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
structinstructsuch asDoghasOwner. (and some refactoring)