Undefined behavior in reinterpret_casts

[wintersteiger]

From #24: Undefined behavior in reinterpret_cast's, one example is this, but there are more:

z3/src/util/hwf.cpp

Line 161 in d01c349

uint64 r = (RAW(s.value) & 0x800FFFFFFFFFFFFFull) | ((exp + 1023) << 52);

[nunoplopes]

I fixed a bunch of these a while back, but I think the merge of the FPA branch undid a few changes. The fix is to use memcpy.

[wintersteiger]

That may well be the case, thanks for the info!

[wintersteiger]

I fixed those in hwf and mpfx, but I didn't touch src/muz/rel/dl_instruction.cpp so as not to break something important. @NikolajBjorner could you take a look at those?

[NikolajBjorner]

I believe this can be closed now