Pass /RELEASE to MSVC linker #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without /RELEASE passed to MSVC linker, the checksum field in exe/dll is not calculated. When you load the exe/dll in windbg (e.g., windbg -z libz3.dll), a warning "Unable to verify checksum" will show. With /RELEASE passed to linker, the warning will be gone.
|
I thought this was already addressed in 8e2ad4e |
|
Do we need to add the linker flag to shared lib building as well? Now it’s
only for exe.
On Thu, Jul 4, 2019 at 6:35 PM Nikolaj Bjorner ***@***.***> wrote:
I thought this was already addressed in 8e2ad4e
<8e2ad4e>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2383?email_source=notifications&email_token=ABQWXQ7JOLM5PEEU2XGHE6TP52QPRA5CNFSM4H54GMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZIKNLQ#issuecomment-508602030>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQWXQZZXW4SGT3SZAJANN3P52QPRANCNFSM4H54GMDQ>
.
--
…--
Thanks,
Ben
|
|
maybe, I don't know. I take this pull request and revert my change as logical place seems to be in CMakeLists.txt contrary to what I previously thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without /RELEASE passed to MSVC linker, the checksum field in exe/dll is not calculated. When you load the exe/dll in windbg (e.g., windbg -z libz3.dll), a warning "Unable to verify checksum", see below, will show. With /RELEASE passed to linker, the warning will be gone.