Skip to content
This repository has been archived by the owner on Jan 4, 2024. It is now read-only.

Undesirable Behaviour in functions.status_print #36

Closed
ZAdamMac opened this issue Nov 11, 2022 · 1 comment
Closed

Undesirable Behaviour in functions.status_print #36

ZAdamMac opened this issue Nov 11, 2022 · 1 comment
Labels

Comments

@ZAdamMac
Copy link
Owner

Describe the bug
Status print currently contains a bug where it is rounding up the completion percentage. While this may initially be desirable for very lengthy operations to get as soon as possible to 1%, it causes an issue where the percentage can become 100% well before the round is actually complete.

When this happens the console is spammed repeatedly with DONE! messages even though the operation is not done, each on its own new line.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a backup against a sufficiently large (say, 300 item) number of files.
  2. Observe.

Expected behavior
The 100% - Done message should only be shown on the final operation in the queue.

Log/Console Output
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!
Packing: [###############] 100% - Done!

Desktop (please complete the following information):

  • OS: Ubuntu 22.04.1 LTS
  • Tapestry Version: 2.1.1 and later.

Additional context
This is probably a minor fix along with the other issues described here, which came from working with production data. Its own minor release is not required if all of the open tickets can be closed reasonably close together.

@ZAdamMac
Copy link
Owner Author

ZAdamMac commented Jun 2, 2023

corrected in commit 3d85d48

@ZAdamMac ZAdamMac closed this as completed Jun 2, 2023
ZAdamMac added a commit that referenced this issue Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant