Add check for stored sizes in parsing #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptahmose
reviewed
Jun 17, 2024
ptahmose
reviewed
Jun 17, 2024
ptahmose
reviewed
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 65.99% 66.01% +0.02%
==========================================
Files 85 85
Lines 10653 10664 +11
==========================================
+ Hits 7030 7040 +10
- Misses 3623 3624 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
What's still missing (aside from functional aspects):
|
ptahmose
reviewed
Jun 18, 2024
ptahmose
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Situation/Motivation:
When checking an image with subblocks with "StoredSize=37" for "H" dimension, CziCheck did pass without error.
As such documents are malformed, parsing should not succeed, at least not for strict parsing.
Change: libCzi checks the stored/pixel size when strict parsing is enabled.
Benefit:
Strict parsing can be enabled in CziCheck, then on parsing an exception is thrown and corrupted/illegal files will not pass CziCheck silently.
Fixes #102
Type of change
How Has This Been Tested?
New functionality checked with CziCmd and a file with size=37 in H-dimension.
Checklist: