Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize CPPLINT #35

Open
FelixS90 opened this issue Feb 7, 2023 · 0 comments
Open

Finalize CPPLINT #35

FelixS90 opened this issue Feb 7, 2023 · 0 comments

Comments

@FelixS90
Copy link
Collaborator

FelixS90 commented Feb 7, 2023

Is your feature request related to a problem? Please describe.
With the completion of #32 we still have some cpplint issues left to fix (or permanently accept) that are currently filtered out in CPPLINT.cfg.

Describe the solution you'd like
Apply some of the fixes primarily applied to Src/libCZI as part of #32 to other parts of the code like:

  • Src/CZICmd
  • Src/JxrDecode
  • Src/libCZI_UnitTests

Src/libCZI largely passed cpplint by applying the following filter:
cpplint_screenshot

Any cpplint issues that are not going to be fixed (either because of feasibility or meaningfulness) should stay in the global CPPLINT.cfg. I strongly advise not to:

  • introduce nested config files or
  • exclude certain subdirectories from scanning

Additional context

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant