-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code compliant with editorconfig and cpplint #32
Conversation
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 47.27% 47.27% -0.01%
==========================================
Files 77 77
Lines 15749 15756 +7
==========================================
+ Hits 7445 7448 +3
- Misses 8304 8308 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the content with "Hide Whitespace", which left over 8 files to review.
As discussed offline, I will try to bring this into a GitHub Action to avoid regressions in the future.
Options:
- Mega-Linter using editorconfig-checker under the hood
EditorConfig-Action
Thanks for this tip, wasn't aware of this feature. Nice! |
Seems that changing space before or after pointer still renders as whitespace-only change which is probably fine since they are equivalent as posted in https://google.github.io/styleguide/cppguide.html#Pointer_and_Reference_Expressions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the first review, I checked all changed files that do not only have white space changes.
I did not check Cpplint related changes for correctness - trusting cpplint itself and tests.
Feel free to resolve all remaining conversations if you are OK with the changes I introduced on top of this PR.
Description
Fixes #31
About every file has been touched in the PR, so it is probably impossible to review it. However - the hope is that this is the last time that we have a change like that (i.e. a massive PR due to formatting changes).
Type of change
How Has This Been Tested?
built locally and ran tests
Checklist: