-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore "CZICmd" demo application #20
Conversation
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage ? 46.20%
=======================================
Files ? 77
Lines ? 15659
Branches ? 0
=======================================
Hits ? 7235
Misses ? 8424
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Reported code coverage is OK -> 46.2% is the same as currently on main. No comparison to base commit since branch seems to have been based on commit prior to introducing codecov. |
Note: Not further reviewing the logic of Src/CZICmd based on PR description stating that this is basically "copied" over from the archived repo and functionally equivalent. |
I'd think so, only ..Src/Doxyfile is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the open conversations/threads. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few open comments.
One thing I just noticed when running doxygen locally (version 1.9.5): Maybe we want to remove the unused flags. I leave this up to you. Info: The last successful run on main was still using 1.8. Most likely, it will then also use 1.9 next time (i.e. upon completion of this PR), but as I said, we can also tackle this later on when we get the warning on the CD build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your plans on adding tests for CZICmd?
Should we still already include it in https://github.com/ZEISS/libczi/blob/main/opencppcoverage.txt (to have visibility through codecov)?
Or should we add an issue (maybe tagged "good first issue") to keep track of it?
What do you think?
added an issue -> #21 |
Added #24 and discussed ideas/options. |
Description
This is adding the sample-application "CZICmd". It is functionally identical with the
version from here, with the following change: the command-line argument parsing has been refactored and is now done with the help of CLI11.
Note: this PR is just adding the code, but CZICmd is not built by default. It needs to be enabled by setting the option "LIBCZI_BUILD_CZICMD" to "ON".
Fix for #18 is included.
Type of change
How Has This Been Tested?
Checklist: