Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zstd to 1 5 6 #97

Merged
merged 18 commits into from
Apr 8, 2024
Merged

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Apr 2, 2024

Description

use the latest version of zstd (https://github.com/facebook/zstd/releases/tag/v1.5.6)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tested locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team April 2, 2024 09:24
ReneBoeckelmann
ReneBoeckelmann previously approved these changes Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (9a7503b) to head (3170f26).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files          85       85           
  Lines       10647    10647           
=======================================
  Hits         7024     7024           
  Misses       3623     3623           
Flag Coverage Δ
windows-latest 65.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Apr 2, 2024
@ptahmose ptahmose merged commit 2e37398 into ZEISS:main Apr 8, 2024
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/update_zstd_to_1_5_6 branch April 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants