Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Week1 #1

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Archive Week1 #1

merged 2 commits into from
Mar 5, 2024

Conversation

QiLOL
Copy link
Contributor

@QiLOL QiLOL commented Mar 5, 2024

Hi, I just archived the Cohort 5 - week1 , please check if it is looks fine, and feel free let me know if changes needed. Thanks!

@socathie socathie merged commit f1fc8b4 into ZK-University:main Mar 5, 2024
@socathie
Copy link
Member

socathie commented Mar 5, 2024

@QiLOL Thanks for your contribution! Looks good as a first draft but I'm thinking maybe we can follow this to embed the video directly in the doc

@QiLOL
Copy link
Contributor Author

QiLOL commented Mar 5, 2024

@QiLOL Thanks for your contribution! Looks good as a first draft but I'm thinking maybe we can follow this to embed the video directly in the doc

Sure, I will follow this for the future pr, thank you!

@socathie
Copy link
Member

@QiLOL Have added this feature request as an issue #3

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants